Skip to content

feat(broker): make Hyperliquid the evidence default#251

Merged
Whiteks1 merged 3 commits intomainfrom
codex/broker-evidence-hyperliquid-first
Apr 4, 2026
Merged

feat(broker): make Hyperliquid the evidence default#251
Whiteks1 merged 3 commits intomainfrom
codex/broker-evidence-hyperliquid-first

Conversation

@Whiteks1
Copy link
Copy Markdown
Owner

@Whiteks1 Whiteks1 commented Apr 4, 2026 •
edited by sourcery-ai bot
Loading

Summary

Make the first supervised broker evidence pass Hyperliquid-first instead of Kraken-first, so the readiness helper and operator guidance match the active execution direction.

Changes included:

  • make broker_evidence_readiness prefer Hyperliquid when both corridors are available
  • update the readiness artifact to report recommended_first_corridor: hyperliquid
  • align the broker evidence runbook with Hyperliquid-first readiness checks
  • update the current-state / roadmap / strategy docs so the active corridor narrative no longer points at Kraken as the default
  • add focused tests for Hyperliquid-first readiness resolution

Why

The repo already had the operational path for supervised Hyperliquid evidence.

What was still inconsistent was the default evidence recommendation and the top-level narrative, which still suggested Kraken-first behavior. This slice removes that friction without touching submit, signing, or live execution behavior.

Scope

This PR does not:

  • change submit behavior
  • change signing logic
  • change readiness gates beyond the corridor recommendation order
  • remove Kraken support from the codebase

It only makes Hyperliquid the active evidence default and aligns the operator-facing docs with that direction.

Validation

Validated with:

  • python -m pytest -q test/test_broker_evidence_readiness.py test/test_app_cli.py
  • python main.py --broker-evidence-readiness-outdir outputs\\broker_evidence_demo --broker-evidence-corridor hyperliquid
  • git diff --check

Notes

  • The readiness command now fails honestly when Hyperliquid credentials are missing, but the artifact still records the Hyperliquid-first recommendation.
  • Kraken remains in the repo as compatibility/history.
  • This is a strategic alignment slice for the first evidence pass, not a live execution change.

Closes #226

Summary by Sourcery

Make Hyperliquid the primary execution venue and broker evidence corridor while keeping Kraken as a compatibility/reference backend, and align readiness logic, tests, and documentation with this direction.

Enhancements:

  • Update broker evidence readiness resolution to prefer Hyperliquid when both Hyperliquid and Kraken are ready and adjust the recommendation metadata accordingly.

Documentation:

  • Revise execution-venue strategy, roadmap, runbook, current-state notes, README, and landing page copy to describe Hyperliquid as the active venue direction and Kraken as a compatibility/reference backend.

Tests:

  • Add a readiness report test that asserts Hyperliquid is selected and recommended when both corridors are configured and credentials are present.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 4, 2026 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 4, 2026
View reviewed changes
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In build_broker_evidence_readiness_report, recommended_first_corridor is now hardcoded to "hyperliquid" even when Hyperliquid is not ready; consider either deriving this from actual readiness/priority or adding an explicit code comment to document why a non-ready corridor can still be recommended.
  • The corridor resolution logic in build_broker_evidence_readiness_report is now encoded as a series of if/elif checks; if you expect to add more venues, it might be worth centralizing the priority ordering in a small helper (e.g., a ranked list of corridors) so the selection rules stay easy to adjust and reason about.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- In `build_broker_evidence_readiness_report`, `recommended_first_corridor` is now hardcoded to `"hyperliquid"` even when Hyperliquid is not ready; consider either deriving this from actual readiness/priority or adding an explicit code comment to document why a non-ready corridor can still be recommended.
- The corridor resolution logic in `build_broker_evidence_readiness_report` is now encoded as a series of `if/elif` checks; if you expect to add more venues, it might be worth centralizing the priority ordering in a small helper (e.g., a ranked list of corridors) so the selection rules stay easy to adjust and reason about.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Whiteks1 Whiteks1 merged commit 3abe7f4 into main Apr 4, 2026
1 of 2 checks passed
@Whiteks1 Whiteks1 deleted the codex/broker-evidence-hyperliquid-first branch April 4, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run first supervised broker evidence pass

1 participant

@Whiteks1